Conversation
* origin/master: (53 commits) add new audit report Use ExitReason::Revert instead of ExitReason::Error (#1772) Claim Account to use Eip-712 (#1755) Benchmark evm (#1674) support evm create rpc and allow H160 default (#1771) Update template files license header. (#1770) Fix collect_fee (#1766) handle nonce for eth tx (#1707) updated to the ORML's test coverage file (#1760) rm runtime upgrade (#1757) Happy new year 2022. (#1761) Excluded some files from test coverage (#1759) XCM: add deposit error handler for multi-currency adapter. (#1756) update stable asset (#1758) Fix test coverage for acala (#1590) Fix collect_fee (#1754) Update HEADER-GPL3 Update extrinsic-ordering-check-from-bin.yml (#1752) Update HEADER-GPL3 bump version (#1751) ...
Codecov Report
@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
+ Coverage 86.07% 86.31% +0.23%
==========================================
Files 89 91 +2
Lines 18923 19813 +890
==========================================
+ Hits 16288 17101 +813
- Misses 2635 2712 +77
Continue to review full report at Codecov.
|
xlc
commented
Jan 22, 2022
zqhxuyuan
reviewed
Mar 2, 2022
runtime/integration-tests/Cargo.toml
Outdated
|
|
||
| xcm-emulator = { git = "https://github.com/shaunxw/xcm-simulator", rev = "a250ffc998bac4831c5692c591dee7bc13f3aead" } | ||
| #xcm-emulator = { git = "https://github.com/shaunxw/xcm-simulator", rev = "a250ffc998bac4831c5692c591dee7bc13f3aead" } | ||
| xcm-emulator = { git = "https://github.com/zqhxuyuan/xcm-simulator", rev = "65832f73b21f55b10dcb09460f8c8ad6ac8083f9" } |
xlc
commented
Mar 3, 2022
| pub ParachainMinFee: |location: MultiLocation| -> u128 { | ||
| #[allow(clippy::match_ref_pats)] // false positive | ||
| match (location.parents, location.first_interior()) { | ||
| (1, Some(Parachain(parachains::statemine::ID))) => 4_000_000_000, |
Member
Author
There was a problem hiding this comment.
this should be managed by XcmInterface pallet so that we can dynamically updating it if needed
syan095
pushed a commit
that referenced
this pull request
Mar 8, 2022
…count * origin/master: (21 commits) udpate predeploy and disable NFT precompile for karura & acala (#1942) remove old migrations (#1937) Optimized calculations t avoid error caused by division missing (#1935) Statemine integration test (#1712) switch to london (#1932) fix clap annotation (#1933) fix package name (#1928) type cleanup (#1931) bump version (#1930) V0.9.17 (#1924) update precompile set (#1929) bump version (#1926) use internal release for dev release fix evm-bench access_list (#1925) add missing precompiles and fixes (#1923) remove legacy trader location (#1920) cdp enhancement (#1886) add new call to execute completely fast match redeem (#1922) Change StorageDepositPerByte (#1919) add ACA to CollateralCurrencyIds (#1918) ... # Conflicts: # Cargo.lock # orml # runtime/integration-tests/src/setup.rs # runtime/integration-tests/src/stable_asset.rs # runtime/mandala/Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration test between Karura & Statemine/Westmint.
Statemine does not support v0.9.13 so we can only use Westmint.closes: #1763
RMRK transfer back to Statemine test based on: open-web3-stack/open-runtime-module-library#700
manual test:
